Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll position/offset (scrollLeft,scrollTop) should be reflected in rendering of scrollable elements, rather than pretending everything is scrolled to the top/left #121

Open
JoolsCaesar opened this issue Apr 28, 2017 · 4 comments · May be fixed by #142

Comments

@JoolsCaesar
Copy link

Use case: description, code

I hoped to use this to generate an image of what the user is currently seeing, however it seems to ignore any scroll offsets (scrollTop/scrollLeft) of elements I'm viewing, so it renders all images as though things had not been scrolled.

I've made a jsfiddle below with a scrollable div containing sequential numbers. If you scroll down to "50" and hit "Render", I'd like that to be reflected in the image, but it seems to pretend the element wasn't scrollable.

jsfiddle

Expected behavior

The content of scrollable element should rendered with it's current scroll offset.

Actual behavior (stack traces, console logs etc)

Elements are rendered as though they were not scrolled.

Library version

2.5.2

Browsers

Chrome 58
Firefox 52

@cnatis cnatis linked a pull request Jul 19, 2017 that will close this issue
@cnatis
Copy link
Contributor

cnatis commented Jul 19, 2017

PR to fix this issue is open #142

It is pretty prototype code so please test before committing to using this feature

@vbguyny
Copy link

vbguyny commented Feb 9, 2020

Any updates on this issue?

@cnatis
Copy link
Contributor

cnatis commented Feb 10, 2020

@vbguyny I believe this repo is mostly dead and hasnt seen any commits in about a year and a half. You might want to look at https://github.com/1904labs/dom-to-image-more which appears to be a fork that is trying to improve support and features more actively.

@vbguyny
Copy link

vbguyny commented Feb 12, 2020

@cnatis thanks, I'll check it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants