Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: README options 'remove' is not functioning as described #334

Closed
jf3096 opened this issue Feb 13, 2020 · 0 comments · Fixed by #336
Closed

bug: README options 'remove' is not functioning as described #334

jf3096 opened this issue Feb 13, 2020 · 0 comments · Fixed by #336

Comments

@jf3096
Copy link

jf3096 commented Feb 13, 2020

I have reviewed the source code and find out that in CLI mode, remove is treated as only. Howerver, in programing mode which I "require('gh-pages')" the following code wont work as source code "config.remove" has never been used.

ghpages.publish('dist', {
  remove: "*.json"
}, callback);
@jf3096 jf3096 changed the title README optiosn remove is not functioning as describe README options 'remove' is not functioning as described Feb 13, 2020
@jf3096 jf3096 changed the title README options 'remove' is not functioning as described bug: README options 'remove' is not functioning as described Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant