Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

django_facebook_open_graph_share table name is changed to django_facebook_opengraphshare ? #523

Open
amarpreetsaini opened this issue Mar 22, 2015 · 2 comments

Comments

@amarpreetsaini
Copy link

I was using an older version of both django and django_facebook previously. I migrated to django 1.7 and installed latest django_facebook. To setup DB table i did following

Ran python manage.py makemigraitons django_facebook

This generated the migration file with table name django_facebook_opengraphshare.

While the makemigration created table name as django_facebook_opengraphshare, the other code is expecting it to be django_facebook_open_graph_share.

To test the issue i changed the migrations file manually and changed the table name to django_facebook_open_graph_share. With this change i was able to successfully do migrations.

So When and why was this change implemented in table name ?
If this is legitimate then why the code in admin.py expecting the older table name ?

@amarpreetsaini amarpreetsaini changed the title django_facebook_open_graph_share table name is changed to django_facebook_opengraphshare ? django_facebook_open_graph_share table name is changed to django_facebook_opengraphshare ? Is #512 a fix for similar issue @vially Mar 23, 2015
@amarpreetsaini amarpreetsaini changed the title django_facebook_open_graph_share table name is changed to django_facebook_opengraphshare ? Is #512 a fix for similar issue @vially django_facebook_open_graph_share table name is changed to django_facebook_opengraphshare ? Is #512 a fix for similar issue. Mar 23, 2015
@vially
Copy link
Contributor

vially commented Mar 23, 2015

I haven't tried the latest versions of django or django-facebook but last time I tried I did not face this issue.

#512 was only meant to add an empty init.py file to the migrations directory because otherwise the new migrations system found in django 1.7 would not recognize the migrations at all (maybe this has changed in the latest version of django?)

@amarpreetsaini
Copy link
Author

My mistake i thought 0001_initial.py was also added by you. But whether you have a table named django_facebook_open_graph_share or django_facebook_opengraphshare.

@amarpreetsaini amarpreetsaini changed the title django_facebook_open_graph_share table name is changed to django_facebook_opengraphshare ? Is #512 a fix for similar issue. django_facebook_open_graph_share table name is changed to django_facebook_opengraphshare ? Mar 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants