Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to ope file .../build-oracle.sql on windows 10 #23

Closed
jiri-kajaba opened this issue Jun 11, 2016 · 3 comments
Closed

Unable to ope file .../build-oracle.sql on windows 10 #23

jiri-kajaba opened this issue Jun 11, 2016 · 3 comments
Assignees
Labels
Milestone

Comments

@jiri-kajaba
Copy link

oracle-build-error

@tschf tschf added the bug label Jun 11, 2016
@tschf tschf added this to the 1.0.0 milestone Jun 11, 2016
@tschf tschf self-assigned this Jun 11, 2016
@tschf
Copy link
Owner

tschf commented Jun 11, 2016

Thanks for the report. I introduced some logic specific to *nix based systems, which passes the package dir to the script. Specifically: https://github.com/tschf/atom-build-oracle/blob/master/lib/make.js#L58 - the array (thisConfig.args) shouldn't have this element on Windows (it has no need for it).

I won't get to this for a couple of weeks.

@vincentmorneau
Copy link

+1 on this issue.

@tschf
Copy link
Owner

tschf commented Jul 6, 2016

Thanks for bumping this and bringing it back on my radar. I just got home yesterday afternoon - will aim to check this out this afternoon (sorry for the delay).

@tschf tschf closed this as completed in 1a6781b Jul 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants