fix: mark properties with @Internal

fixes #44
tschulte · May 17, 2021 · 945d94e · 945d94e
1 parent 2ae46fd
commit 945d94e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/src/main/groovy/de/gliderpilot/gradle/semanticrelease/UpdateGithubRelease.groovy b/src/main/groovy/de/gliderpilot/gradle/semanticrelease/UpdateGithubRelease.groovy
@@ -20,6 +20,7 @@ import org.gradle.api.DefaultTask
 import org.gradle.api.logging.Logger
 import org.gradle.api.logging.Logging
 import org.gradle.api.tasks.Input
+import org.gradle.api.tasks.Internal
 import org.gradle.api.tasks.TaskAction
 
 class UpdateGithubRelease extends DefaultTask {
@@ -38,6 +39,7 @@ class UpdateGithubRelease extends DefaultTask {
         project.version.inferredVersion
     }
 
+    @Internal
     protected String getTagName() {
         project.release.tagStrategy.toTagString(version.version)
     }
@@ -47,10 +49,12 @@ class UpdateGithubRelease extends DefaultTask {
         return repo.releaseAssets
     }
 
+    @Internal
     GithubRepo getRepo() {
         project.semanticRelease.repo
     }
 
+    @Internal
     SemanticReleaseChangeLogService getChangeLog() {
         project.semanticRelease.changeLog
     }

diff --git a/...liderpilot/gradle/semanticrelease/integration/SemanticReleasePluginIntegrationSpec.groovy b/...liderpilot/gradle/semanticrelease/integration/SemanticReleasePluginIntegrationSpec.groovy
@@ -89,6 +89,13 @@ class SemanticReleasePluginIntegrationSpec extends IntegrationSpec {
     def setupGradleProject() {
         buildFile << """
             apply plugin: 'de.gliderpilot.semantic-release'
+            semanticRelease {
+                repo.ghToken = 'anything'
+                repo.useGhEnterprise('https://example.com')
+            }
+            tasks.updateGithubRelease.actions.clear()
+            tasks.updateGithubRelease.doFirst {
+            }
             """.stripIndent()
     }