Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: incorrect computation of instrument limits #69

Open
mducle opened this issue Feb 9, 2023 · 0 comments
Open

Bug: incorrect computation of instrument limits #69

mducle opened this issue Feb 9, 2023 · 0 comments

Comments

@mducle
Copy link
Collaborator

mducle commented Feb 9, 2023

The function sw_instrument has code which computes the kinematic limits of the detectors. Unfortunately it assumes that the detectors span the range of scatterings [thetaMin, 180-thetaMin] and allows only a single argument for this computation thetaMin.

In fact, it is not physically feasible for most spectrometers to cover up to 180 degrees scattering angle. Thus a thetaMax parameter should be allowed and the expressions in the code modified. In practice most instruments cover around 120-130 degrees in scattering angle, and some cover an even more restricted range of around 60 degrees.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant