Upgraded to 1.4.0, but it seems like next()/response.send() isn't called within the passport example

[zoubarevm]

Hey!

I'm not entirely sure why, but it seems like the following method never really triggers the next()/ response.send() functions (even though it's returned as a promise) and the server hangs when I call login using 1.4.0.

Let me know if you have any ideas on where I could look to resolve this.

Cheers!

/**
     * Authenticate user with local info (in Database).
     * @param email
     * @param password
     * @param request
     * @param response
     * @param next
     */
    @Post('/login')
    public login(
        @Required() @BodyParams('email') email: string,
        @Required() @BodyParams('password') password: string,
        @Request() request: Express.Request,
        @Response() response: Express.Response,
        @Next() next: Express.NextFunction
    ) {
        console.log('resquest.cookies', request.cookies);

        return new Promise<IUser>((resolve, reject) => {

            try{
                Passport
                    .authenticate('login', (err, user: IUser) => {

                        if (err) {
                            reject(err);
                        }

                        request.logIn(user, (err) => {

                            if (err) {
                                reject(err);
                            }

                            resolve(user);
                        });

                    })(request, response, next);
            }catch (er){
                console.error(er);
            }
        })
            .catch((err) => {

                if(err && err.message === "Failed to serialize user into session") {
                    throw new NotFound('user not found');
                }

                return Promise.reject(err);
            });

    }

EDIT

Adding something like following after the promise creation seems to resolve this:

...
         .then(x => {
            response.send(x);
            next();
        })
...

[Romakita]

Hi @zoubarevm ,

Effectively, it's a bug about the new middleware management, when you use @Next() and return a promise at the same time.

v1.4.1 fix them :)

Thanks a lot :)

[zoubarevm]

@Romakita awesome! Just tried it and it works :)

Thanks for your help!