Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Depend on libgtk-3-0 | libgtk2.0-0, don't require both #4

Merged
merged 1 commit into from
Mar 21, 2018
Merged

Depend on libgtk-3-0 | libgtk2.0-0, don't require both #4

merged 1 commit into from
Mar 21, 2018

Conversation

ginggs
Copy link
Contributor

@ginggs ginggs commented Dec 31, 2017

@jbicha
Copy link
Member

jbicha commented Dec 31, 2017 •
edited

It is not practical to run Ubuntu 18.04 without gtk3 installed. For instance, both supported web browsers, Firefox and Chromium use gtk3.

Therefore, I suggest you instead try something like the last 2 lines of
https://salsa.debian.org/gnome-team/gnome-themes-extra/blob/debian/master/debian/rules

@jbicha
Copy link
Member

jbicha commented Mar 9, 2018

@ginggs Do you want to try my approach ^ instead?

@ginggs
Copy link
Contributor Author

ginggs commented Mar 9, 2018

@jbicha No, it seems your approach depends on gtk3 only, not gtk3 or gtk2.

@ginggs
Copy link
Contributor Author

ginggs commented Mar 9, 2018

@tseliot I've just pushed the commit with a change included in nvidia-settings 387.34-2 uploaded to Debian on 2018-03-06.

Let me know if you want this branch squashed and rebased.

@tseliot
Copy link
Contributor

tseliot commented Mar 9, 2018

@ginggs sure, that would help, thanks.

@jbicha
Copy link
Member

jbicha commented Mar 9, 2018

@ginggs Yes, that is intentional. You need to have gtk3 installed anyway. There's no reason someone would have gtk2 installed but not gtk3 in 2018.

@ginggs
Copy link
Contributor Author

ginggs commented Mar 9, 2018

@jbicha nvidia-settings runs on Nvidia Jetson ARM boards, one might not need to have a web browser installed

@tseliot tseliot merged commit 3c3e077 into canonical:master Mar 21, 2018
@ginggs ginggs deleted the gtk3-or-gtk2 branch March 21, 2018 19:03
@jbicha
Copy link
Member

jbicha commented Apr 4, 2018

@ginggs Ok, but that's not much of a justification. gtk2 is being slowly removed from distros and doesn't have any advantages compared to gtk3 here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ginggs @jbicha @tseliot