Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invalid URLs are reported as 505 HTTP Version Not Supported #106

Closed
agenteo opened this issue Dec 17, 2014 · 4 comments
Closed

invalid URLs are reported as 505 HTTP Version Not Supported #106

agenteo opened this issue Dec 17, 2014 · 4 comments

Comments

@agenteo
Copy link

agenteo commented Dec 17, 2014

I had a few malformed URLs containing markup left from a crawling an HTML page. This is definitely user mistake but vegeta was reporting those as 505 (505 HTTP Version Not Supported
The server does not support the HTTP protocol version used in the request.)

What do you think about flag and ignore invalid URLs?

Example URL causing problem:

GET valid_url" class="accordion-toggle-sub"
@tsenart
Copy link
Owner

tsenart commented Dec 19, 2014

I don't think ignoring errors is a good practice in general.

@agenteo
Copy link
Author

agenteo commented Dec 20, 2014

Agreed but I think returning a 505 (HTTP Version Not Supported) isn't the most informative error and when it appeared in my load test it made me wonder for a while what was wrong.

Anyways today from home (using the binary) I was unable to reproduce this, when I tried:

GET http://example.com/?terms=6e4c7aff-f80b-42be-aaa1-3cd876ab3d87&nav-item=Planning%20101" class="accordion-toggle-sub"

I got a 400 Bad Request which is what you'd expect. It's weird I didn't get the same behaviour when running the load test with malformed URL from my work laptop.

If I can't reproduce it back there I'll close this down.

@tsenart
Copy link
Owner

tsenart commented Jan 3, 2015

@agenteo: Did you manage to reproduce the bug?

@agenteo
Copy link
Author

agenteo commented Jan 5, 2015

Nope. But thanks for following up.

@agenteo agenteo closed this as completed Jan 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants