Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sharing and searching #93

Closed
TsimpDim opened this issue Dec 29, 2018 · 2 comments
Closed

Fix sharing and searching #93

TsimpDim opened this issue Dec 29, 2018 · 2 comments
Labels

Comments

@TsimpDim
Copy link
Owner

After #92 there were many problems if for example you actually didn't want filters and wanted basic search.

Sharing is broken due to the whitespace (which was supposedly fixed) since global whitespace removal was used but spacing is allowed within the tags themselves.

Searching is broken due to the same reasons.

Sharing is also broken due to the wrong query and it being useless if we don't want filters.

So, by and large, what needs to be fixed is adaptability in case the user isn't using filters

@TsimpDim
Copy link
Owner Author

Whitespace changes are not in the compact view

@TsimpDim
Copy link
Owner Author

Changes made in #95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant