Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Was versionCode decreased after v2.1.0? #241

Closed
IzzySoft opened this issue Aug 18, 2023 · 9 comments
Closed

Was versionCode decreased after v2.1.0? #241

IzzySoft opened this issue Aug 18, 2023 · 9 comments
Labels
bug Bug fix. Something isn't working

Comments

@IzzySoft
Copy link

I just was wondering why updates to the latest version failed. Looks like v2.2.1 has versionCode: 13 while v2.1.0 had versionCode: 1011, so Android considers it a downgrade. A closer look reveals: You no longer provide per-ABI builds but just a single "universal APK", hence that "Flutter rule" setting the versionCode to 1000 + versionCode for armeabi no longer applies.

May I ask to make per-ABI builds available again? That would also reduce the download size significantly (per-ABI was ~8MB, universal now is at ~24MB). That done, you could also pick a badge to link to your app in my repo next to the one from Google, as then recent versions would become available there again (currently they are removed as being "older") 😉

Thanks in advance!

@IzzySoft IzzySoft added the bug Bug fix. Something isn't working label Aug 18, 2023
@tsinis
Copy link
Owner

tsinis commented Aug 18, 2023

@IzzySoft Thanks for raising the issue, I definitely can do such an adjustment, however, I'm not sure about when the next release will be so you can actually benefit from it :-/. Let's see, thanks again!

@IzzySoft
Copy link
Author

Thanks for your fast reply, @tsinis! I'd say a day or a week or even a month would not matter much now. It just came up at my end as there were no updates for more than a year – at which point one of my scanners reports to me to take a look 😉

And basically, no much change needed. You could even simply add the armeabi build for know (based on the same commit of that last tag – so no new release needed), and everything else can be done later.

@IzzySoft
Copy link
Author

Please give me a ping here when I shall take another look. Everything at your pace of course, no pressure – I just want to make sure in the end it's not me having missed your fix 😉

@tsinis
Copy link
Owner

tsinis commented Aug 19, 2023

Please give me a ping here when I shall take another look. Everything at your pace of course, no pressure – I just want to make sure in the end it's not me having missed your fix 😉

Sure, I will, no worries.

@tsinis
Copy link
Owner

tsinis commented Aug 19, 2023

@IzzySoft please take a look at release 2.2.2. Release CI is now using split-per-abi flag.

@IzzySoft
Copy link
Author

Looks good:

$ iod repo get is.tsin.colors_ai.colors_ai
is.tsin.colors_ai.colors_ai: looking for 'https://api.github.com/repos/tsinis/colors_ai/releases'
is.tsin.colors_ai.colors_ai: checking tag '2.2.2'
is.tsin.colors_ai.colors_ai: lastRelNo set to '2.2.2', checking for files
is.tsin.colors_ai.colors_ai: Upstream file date (2023-08-19 21:26) is newer than ours (2022-07-09 02:00).
is.tsin.colors_ai.colors_ai: returning ['2.2.2','https://github.com/tsinis/colors_ai/releases/download/2.2.2/colors-ai-armeabi-v7a.apk',1692473206]
is.tsin.colors_ai.colors_ai: 2.1.0/2.2.2, https://github.com/tsinis/colors_ai/releases: https://github.com/tsinis/colors_ai/releases/download/2.2.2/colors-ai-armeabi-v7a.apk
- Grabbing update for is.tsin.colors_ai.colors_ai: OK
- Checking 'repo/is.tsin.colors_ai.colors_ai_1014.apk' for libraries and malware …
is.tsin.colors_ai.colors_ai: check if repo contains FUNDING.yml
is.tsin.colors_ai.colors_ai: looking for 'https://api.github.com/repos/tsinis/colors_ai/contents/.github'
is.tsin.colors_ai.colors_ai: looking for 'https://api.github.com/repos/tsinis/colors_ai/contents/'
is.tsin.colors_ai.colors_ai: no FUNDING.yml detected.
is.tsin.colors_ai.colors_ai: no Fastlane configured, skipping Fastlane check.

And to answer unasked questions on the last 2 lines:

So all fine, thanks a lot! Feel free to close this issue (as it's solved) or leave it open adding questions left on your end.

@tsinis
Copy link
Owner

tsinis commented Aug 19, 2023

@IzzySoft Yes it's correct I don't have a FUNDING.yml in this repo and I'm not using Fastlane in any of my projects (GitHub workflows + Codemagic are enough for my needs). Thanks, I'm closing.

@tsinis tsinis closed this as completed Aug 19, 2023
@IzzySoft
Copy link
Author

I'm not using Fastlane in any of my projects

If you had, my updater would fetch that along with new releases. Of course you can also ping me if changes are needed.

@tsinis
Copy link
Owner

tsinis commented Aug 19, 2023

I'm not using Fastlane in any of my projects

If you had, my updater would fetch that along with new releases. Of course you can also ping me if changes are needed.

Sure I would change my mind - I will let you know. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug fix. Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants