Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#373) Fix pi = 4 in amd64 assembly-gen #393

Merged
merged 1 commit into from May 29, 2021
Merged

(#373) Fix pi = 4 in amd64 assembly-gen #393

merged 1 commit into from May 29, 2021

Conversation

herrhotzenplotz
Copy link
Contributor

  • Clean out rax before doing the comparison to sweep out the upper
    bits as only the lower 16 bits get set (Thanks to abridgewater)
  • Fix cleaning xmm0 (Thanks to kolumbetko)

- Clean out rax before doing the comparison to sweep out the upper
  bits as only the lower 16 bits get set (Thanks to abridgewater)
- Fix cleaning xmm0 (Thanks to kolumbetko)
@herrhotzenplotz herrhotzenplotz changed the title (373) Fix pi = 4 in amd64 assmbly-gen (373) Fix pi = 4 in amd64 assembly-gen May 29, 2021
@herrhotzenplotz herrhotzenplotz changed the title (373) Fix pi = 4 in amd64 assembly-gen (#373) Fix pi = 4 in amd64 assembly-gen May 29, 2021
@zhiayang
Copy link
Contributor

if you want to save 1 byte for each xor, you can use xor eax, eax as well :D

@herrhotzenplotz
Copy link
Contributor Author

if you want to save 1 byte for each xor, you can use xor eax, eax as well :D

<insert rant on x86/>
but then I'd go through the entire generator and change rax to eax to make it consistent. I guess that is another issue.

@zhiayang
Copy link
Contributor

zhiayang commented May 29, 2021

it's fine to leave it like this, more consistent anyway.

@rexim
Copy link
Member

rexim commented May 29, 2021

@herrhotzenplotz @kolumb @abridgewater looks goode to me! 👍 Thank you for your contribution!

@rexim rexim merged commit bb5f8c3 into tsoding:master May 29, 2021
@herrhotzenplotz herrhotzenplotz deleted the 373 branch May 29, 2021 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants