-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some zip files can't be extracted #42
Comments
See tsolomko/SWCompression#42 for the changes to the decompression function
Hi, The cause of this issue is that the ZIP archive in your first example does not contain an entry for the "examples" directory, so it is not created when extracting an archive, and thus creating a file inside a non-existent directory fails. This is not an issue with SWCompression itself, as it is not its goal to evaluate the contents of the archives it is processing apart from the general format correctness (and there is no provision in ZIP format specifications that requires the existence of directory entries). It can be argued that swcomp should check for this situation and I am still deliberating if/how/when this issue should be fixed, but as a general reminder, swcomp is not intended for general use. |
Ah ok. I apologize for the disturbance. I will close the issue |
I tested it with the develop branch and the tag 4.8.5
The text was updated successfully, but these errors were encountered: