This repository has been archived by the owner on Jun 23, 2020. It is now read-only.
Saving request payload for retry purpose #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -9,14 +9,14 @@ def initialize(app, options = {}) | |||
|
|
|||
| def call(env) | |||
| retries = @retries | |||
| interval = @interval | |||
There was a problem hiding this comment.
Removed this variable as its not being used anywhere in the method
|
Thanks for the pull request @manvil! |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tstachl
I have observed that when the API hits the rate limit for the current time slice the API throws Invalid JSON error.
Upon deeper investigation I found that the issue is because when retry is attempted after rate limit has been hit, the request which is sent has the response payload of the first API call. This probably causes issues with the Desk server and hence a BadRequest Error is raised. My change is pretty simple where we store the original request env and upon retry the saved env is used rather than the request modified env.
Regards,
Manvil