test_sql.sh is failing in Gentoo

[bowlofeggs]

When I build lnav in Gentoo with tests enabled, test_sql.sh fails. I see this in test_sql.sh.log:

test: ../src/lnav-test -d /tmp/lnav.err -n -c :goto 1 -c :create-logline-table join_group -c :goto 2 -c ;select logline.log_line as llline, join_group.log_line as jgline from logline, join_group where logline.col_0 = join_group.col_2 -c :write-csv-to - /var/tmp/portage/app-admin/lnav-0.9.0/work/lnav-0.9.0/./test/logfile_for_join.0
querying against stdin is not working?
--- -   2021-01-27 21:21:52.958134889 -0500
+++ test_sql.sh_65.tmp  2021-01-27 21:21:52.948912958 -0500
@@ -1,4 +1,4 @@
         log_time
-2020-11-03 09:23:38.000
-2020-11-03 09:23:38.000
-2020-11-03 09:23:38.000
+2021-11-03 09:23:38.000
+2021-11-03 09:23:38.000
+2021-11-03 09:23:38.000
FAIL test_sql.sh (exit status: 1)

This issue was originally reported in gentoo #713600 with lnav 0.8.5, but I have confirmed that it is still happening with 0.9.0 in Gentoo.

[tstack]

I think this is fixed by commit 60dde49 and there was a subsequent commit that fixed another test in that file. Would you be able to test the top-of-tree?

[bowlofeggs]

Hey @tstack! Sorry for the absurd delay in trying that patch out. Well… I tried it and it worked! I also needed cc072d2 as you had hinted.

I've opened gentoo/gentoo#20975 with those two patches, which should allow us to close that Gentoo issue linked above.

As per your request, I did also try the latest master ( 8f03a44 ) in gentoo, and I do see two problems. test_mvwattrline.sh fails, and the test suite also seems to hang. This is what I see:

$ make -j8 check
…
make  check-TESTS
make[2]: Entering directory '/devel/lnav/test'
make[3]: Entering directory '/devel/lnav/test'
PASS: test_auto_mem
PASS: test_abbrev
PASS: test_auto_fd
PASS: test_bookmarks
PASS: test_ansi_scrubber
PASS: test_date_time_scanner
PASS: test_format_installer.sh
FAIL: test_mvwattrline.sh
PASS: lnav_doctests
PASS: test_cli.sh
PASS: test_grep_proc2
PASS: test_listview.sh
PASS: test_log_accel
PASS: test_format_loader.sh
PASS: test_grep_proc.sh
PASS: test_reltime
PASS: test_meta.sh
PASS: test_shlexer.sh
PASS: test_config.sh
PASS: test_sql_anno.sh
PASS: test_sql_coll_func.sh
PASS: test_sql_json_func.sh
PASS: test_sql_fs_func.sh
PASS: test_sql_str_func.sh
PASS: test_sql_time_func.sh
PASS: test_sql_xml_func.sh
PASS: test_tui.sh
PASS: test_data_parser.sh

And then no further output. I don't notice any CPU or I/O usage, so I'm not sure what it is doing.

I am happy to consider the original issue I filed about to be closed. Would you like me to open new issues about the hanging and failing tests?

[tstack]

Closing since the original issue is fixed. Yes, feel free to open new ones, which I think you did.