Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OBC simulator extensions #7

Closed
tstana opened this issue Mar 14, 2019 · 3 comments
Closed

OBC simulator extensions #7

tstana opened this issue Mar 14, 2019 · 3 comments
Assignees

Comments

@tstana
Copy link
Owner

tstana commented Mar 14, 2019

Extensions to the Arduino-based OBC simulator should be implemented as independently as possible from the actual OBC simulator code. The latter resides in a separate repository and is generated (as of the time of writing of this issue) using a config file. The OBC simulator repository may change at a later date, at which point CUBES will need to regenerate the code for its OBC simulator. At that point, adding the extensions to the the newly-generated OBC simulator code may lead to headaches.

The process should be simplified by:

  1. Moving extension code outside of code generated for the OBC simulator, e.g., in new files called extension.c and extension.h;
  2. Modifying the main flie of the OBC simulator to contain calls to functions in extension.h;

All of these should be added to the obcsim/ folder of the repository.

@tstana
Copy link
Owner Author

tstana commented Apr 2, 2019

Thinking about this problem a bit more, maybe the best way to go is to have this extensibility feature supported by the msp-simulator repository directly.

I shall open up an issue there to see if this is possible to implement.

Comments welcome!

@tstana
Copy link
Owner Author

tstana commented Apr 2, 2019

See discussion here:

https://gitlab.com/kth-mist/msp-simulator/issues/5

@tstana
Copy link
Owner Author

tstana commented Jun 3, 2020

Closing issue, CUBES has implemented their custom extensions under the proto-cubes-obc repository.

@tstana tstana closed this as completed Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants