Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split code in Kvantum.cpp? #211

Closed
CDrummond opened this issue Jun 8, 2018 · 6 comments
Closed

Split code in Kvantum.cpp? #211

CDrummond opened this issue Jun 8, 2018 · 6 comments

Comments

@CDrummond
Copy link
Contributor

Kvantum.cpp is >18000 lines of code. Perhaps this could be refactored into smaller files?

@tsujan
Copy link
Owner

tsujan commented Jun 8, 2018

Yes, I'll do it sooner or later but in a way that doesn't make its changing hard to me. Working with a single file has been easier until now, perhaps, because of the nature of the program.

@CDrummond
Copy link
Contributor Author

I agree. Only reporting as its part of the Ubuntu community discussion on using Kvantum - likewise for the license change and XDG_DATA_DIRS

@tsujan
Copy link
Owner

tsujan commented Jun 8, 2018

I agree. Only reporting as its part of the Ubuntu community discussion on using Kvantum

You and I are familiar with things they couldn't know of ;)

I leave this open because the idea occurred to me too. However, I haven't found a practical way of doing it yet. All those functions are closely related to each other and are documented on a single page of Qt doc.

@CDrummond
Copy link
Contributor Author

Well, that theme searching code be separated out :-)

@tsujan
Copy link
Owner

tsujan commented Jun 8, 2018

I agree. Your codes might need a separate file too.

@tsujan
Copy link
Owner

tsujan commented Jul 4, 2018

Splitting done. Kvantum.cpp is still big but it wasn't my goal to reduce its size at all costs; just separated event filtering, polishing and rendering from it but left theme searching code there for now. I can read it more easily now ;) I might do more splitting later.

@tsujan tsujan closed this as completed Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants