Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

!!! bug? scan the table, count of PartialFlagPerResult is not equal to CellsPerResult ? #81

Closed
lungfei opened this issue Feb 1, 2018 · 8 comments · May be fixed by #118
Closed

!!! bug? scan the table, count of PartialFlagPerResult is not equal to CellsPerResult ? #81

lungfei opened this issue Feb 1, 2018 · 8 comments · May be fixed by #118

Comments

@lungfei
Copy link

lungfei commented Feb 1, 2018

when scanner.Next() called, the client crash with error: index out of range
the reason is when i scan the table, the count of CellsPerResult is n (n>0), the count of PartialFlagPerResult is 0. but why the count of PartialFlagPerResult is 0?
@lungfei lungfei changed the title scan the table, count of PartialFlagPerResult is not equal to CellsPerResult ? !!! bug? scan the table, count of PartialFlagPerResult is not equal to CellsPerResult ? Feb 1, 2018
@lungfei
Copy link
Author

lungfei commented Feb 1, 2018

hrpc/scan.go DeserializeCellBlocks() 239:
scanResp := m.(*pb.ScanResponse)
partials := scanResp.GetPartialFlagPerResult()
partials = make([]bool, len(scanResp.CellsPerResult), len(scanResp.CellsPerResult))
scanResp.Results = make([]*pb.Result, len(partials))
make partials size is equal to CellsPerResult is ok, but i don't know true or false.

@timoha
Copy link
Collaborator

timoha commented May 24, 2018

What version of HBase are you running?

@lungfei
Copy link
Author

lungfei commented Aug 10, 2018

sorry to reply late, HBase version is 1.2.

@WanliTian
Copy link

+1

@WanliTian
Copy link

i have found the reason why len(CellsPerResult) is not equal to len(PartifalFlagsPerResult)
https://blogs.apache.org/hbase/entry/scan_improvements_in_hbase_1

@WanliTian
Copy link

@lungfei 1.2 is ok

@Inphi
Copy link

Inphi commented May 24, 2019

Partial flags shouldn't be relied on as they aren't even transmitted by hbase server versions between 1.0.0 and 1.0.3.

Inphi added a commit to Inphi/gohbase that referenced this issue May 26, 2019
@Inphi
hrpc: don't always expect partials for scan
aeca620 
Older hbase versions (e.g. 1.0.x) do not support partials. If partials aren't
provided by the regionserver then treat the cell results as complete.

Closes tsuna#81
@Inphi Inphi mentioned this issue May 26, 2019
Open
Inphi added a commit to Inphi/gohbase that referenced this issue May 26, 2019
@Inphi
hrpc: don't always expect partials for scan
6fdb4a7 
Older hbase versions (e.g. 1.0.x) do not support partials. If partials aren't
provided by the regionserver then treat the cell results as complete.

Closes tsuna#81
@Inphi
Copy link

Inphi commented May 26, 2019

@lungfei I have a branch that addresses this issue. Please let me know if that works for you too.

@dethi dethi closed this as not planned Won't fix, can't repro, duplicate, stale Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

hrpc: don't always expect partials for scan Inphi/gohbase
5 participants
@timoha @dethi @WanliTian @Inphi @lungfei