Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running mypy with reviewdog has no output #111

Closed
vnmabus opened this issue Jan 23, 2024 · 5 comments
Closed

Running mypy with reviewdog has no output #111

vnmabus opened this issue Jan 23, 2024 · 5 comments

Comments

@vnmabus
Copy link

vnmabus commented Jan 23, 2024

I am trying to use your action in another project, but I have problems making it work:

  • First, if an error occurs during the action setup (installation, install_types, etc), the action happily returns an ok status and does nothing.
  • Second, the step "Running mypy with reviewdog 🐶 ..." shows no output and passes without errors, even when there are typing errors in the project:
@tsuyoshicho
Copy link
Owner

Answer will be a little late

@vnmabus
Copy link
Author

vnmabus commented Jan 24, 2024

I solved 2 (it was caused by misconfiguration, but I still think that errors should be reported). Problem 1 remains, though.

@tsuyoshicho
Copy link
Owner

@vnmabus
I'm glad it was resolved.

Regard

@tsuyoshicho
Copy link
Owner

Consider this issue.

First, if an error occurs during the action setup (installation, install_types, etc), the action happily returns an ok status and does nothing.

@tsuyoshicho
Copy link
Owner

Hi @vnmabus

Issue and will proceed to respond to the issue.

Thank you for your report.
As for this Issue, we will close it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants