Read mypy arguments from config file

[vnmabus]

It appears that mypy arguments in setup.cfg are not read. As a result, the action reports different errors than executing mypy locally.

[tsuyoshicho]

Thanks report.

I inv. it.

[tsuyoshicho]

Mr @vnmabus ,

Create test branchs.

• with setup.cfg test: mypy re-test (without setup.cfg) action-test-repo#11
• without setup.cfg test: mypy re-test (with setup.cfg) action-test-repo#12

Test code as same.

setup.cfg see below:

[mypy]
warn_no_return = False

with setup.cfg test do no report Missing return statement.
That's fine.

As far as the results are concerned, it reads setup.cfg and works correctly.

Please your action-mypy setting (filter-mode, mypy_flags...) to check in workflow what you needed.

[vnmabus]

I still do not get what I am doing wrong.

I have this PR: GAA-UAM/scikit-fda#296
In the setup.cfg I have set the option implicit_reexport for mypy, and it works locally.
However action-mypy is still reporting Module '...' has no attribute '...' errors.

The code for the workflow is

name: Mypy

on:
  pull_request:

jobs:
  build:
    runs-on: ubuntu-latest
    name: Mypy
    steps:
    - uses: actions/checkout@v2
    - uses: tsuyoshicho/action-mypy@v1
      with:
        github_token: ${{ secrets.github_token }}
        # Change reviewdog reporter if you need [github-pr-check,github-check,github-pr-review].
        reporter: github-pr-review
        # Change reporter level if you need.
        # GitHub Status Check won't become failure with warning.
        level: warning

[tsuyoshicho]

Note:
https://mypy.readthedocs.io/en/stable/config_file.html#confval-implicit_reexport

implicit_reexport = True

[vnmabus]

But it IS written like that... The mypy section is

[mypy]
strict = True
strict_equality = True
implicit_reexport = True

[tsuyoshicho]

Thanks, I tried your repo in local... now

[tsuyoshicho]

Tried local, get below:

skfda\representation\_functional_data.py:25:1: error: Module 'skfda._utils' has no attribute '_evaluate_grid'

same as https://github.com/GAA-UAM/scikit-fda/pull/296/files#r546687283

run as mypy --show-column-numbers --strict --strict-equality skfda\_utils\_utils.py

mypy installed global, no-plugin / standalone.

This result seem to be correct.

munnn...

[vnmabus]

I think that I know what is happening here... Your action is calling mypy with flags by default, and the -strict flag takes precedence over the implicit_reexport in the config.

[vnmabus]

I guess that I could change mypy_flags to the empty string and it should work. I am not sure if invoking the tool with arguments by default is the wisest option, since as we have already seen it creates differences between local and repo errors.

[vnmabus]

Changing mypy_flags to the empty string seems to work, you can close this if you want.

[tsuyoshicho]

Okay, I understand everything.

• This issue was closed
• Rethink the default arguments.

Regards.