Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joint restraints when the input is a list #34

Closed
anagpuyol opened this issue Jan 22, 2015 · 8 comments
Closed

Joint restraints when the input is a list #34

anagpuyol opened this issue Jan 22, 2015 · 8 comments
Assignees
Labels
Milestone

Comments

@anagpuyol
Copy link
Contributor

image

@anagpuyol
Copy link
Contributor Author

Never mind, I got that to work, but the joints come out with no dyn label assigned
image

@anagpuyol
Copy link
Contributor Author

Also, when I pass the frames and the joints together I get the duplicate warning in the collector

@anagpuyol
Copy link
Contributor Author

and they are missing in SAP

@anagpuyol
Copy link
Contributor Author

General discussion here:

For frames, we have been creating a new label when the load is set, as seen below. I think we should keep the same label and run the checkDuplicates method inside the collector. If the elements have different labels, we can't know if they are the same one, and thus the user might input the same element twice. I am exemplifying this on joints, where both are dyn_0.

Now, there is a bug in the creation of the IDs, which starts from zero on both joints and frames. We could add a prefix for the type of element: dyn_frm_0, dyn_joint_0, dyn_cable_0, dyn_shell_0 or keep track of all them in the trace cache. I like having a different label because one can easily check in the list what type of elements they are, but I also see how just "dyn_" is very clean. Thoughts @bhowes-tt @eertugrul ?

image

@eertugrul
Copy link
Member

yes I agree with u for the first part, we have just talked, we are creating a new member but we are passing the label then we check the duplicated items at Collector node.

I set separate Trace mechanisms(TracedManager) for the objects such as Frame, Shell and Joint for now cable will be following next phase. So the labels' string format is the same but this doesn't create any problem on SAP and in Dynamo. The names are unique for each type of structure. Element class has Type enum, each time we create object we pass the appropriate type.

🌹

@anagpuyol
Copy link
Contributor Author

This has already been addressed and fixed

@anagpuyol anagpuyol reopened this Feb 4, 2015
@bhowes-tt
Copy link
Member

I couldn't quite understand the issue during our meeting today, but it sounded like it still needs to be resolved... Assigning @anagpuyol

@eertugrul
Copy link
Member

now it is working ! Beware the list should be Flatten list before collector! working now.
image

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants