Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verification failed, error handling #1

Open
iclou opened this issue Oct 17, 2015 · 2 comments
Open

verification failed, error handling #1

iclou opened this issue Oct 17, 2015 · 2 comments

Comments

@iclou
Copy link

iclou commented Oct 17, 2015

If the verification of a signed email fails, how does the error handling look like?

From kryptomime there is not much support, the respective result variables are just 'boolean' without indicating any reason of thhe failure.

Any chance to improve by providing some more information about the failure of the verification?

Thanks for any clarification
S

@iclou
Copy link
Author

iclou commented Oct 22, 2015

File: pgp.py
Function: _check_signature

Please can you remove the line
if not result: continue # no valid signature

Then the calling script gets the full gpg error message -

Thanks for taking this into consideration
S

@iclou iclou closed this as completed Oct 22, 2015
@ttanner
Copy link
Owner

ttanner commented Oct 22, 2015

Thank you for the report.
Just removing the line would return also failed verfications (e.g, for unknown keys), which IMO should be handled separately. I'll give it some thought.

@ttanner ttanner reopened this Oct 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants