Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change fluid importer behavior #24

Closed
hjae78 opened this issue May 14, 2021 · 3 comments
Closed

Change fluid importer behavior #24

hjae78 opened this issue May 14, 2021 · 3 comments

Comments

@hjae78
Copy link

hjae78 commented May 14, 2021

Issue description: In GregTech there are machines with several fluid output slots, the fluid importer can only drain from the first non-empty fluid slot.

What happens: The importer on fluid mode only imports fluids from the first slot.

What you expected to happen: That the importer can import fluid from any slot.

Steps to reproduce:

  1. Using GTCE run any recipe that results in 2 or more fluids.
  2. Try to import a fluid that isn't in the first slot from the left.

Basically the issue is here. It should loop over the fluid tank properties like here.

@tth05 tth05 closed this as completed in 1f33f8f May 15, 2021
@tth05
Copy link
Owner

tth05 commented May 15, 2021

Thanks for the hint!

@hjae78
Copy link
Author

hjae78 commented May 15, 2021

Thank you for the quick fix! The mod I manage, Gregicality, actually has some more coremod fixes for Refined Storage. Refined Storage can't shift click GTCE tools into crafting grid. This is our coremod for RS.

@tth05
Copy link
Owner

tth05 commented May 15, 2021

I'm not exactly sure what those hooks are supposed to accomplish, but inserting and extracting works for me with meta items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants