Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve headers hierarchy #28

Closed
ggarnier opened this issue Dec 12, 2016 · 2 comments · Fixed by #29
Closed

Improve headers hierarchy #28

ggarnier opened this issue Dec 12, 2016 · 2 comments · Fixed by #29

Comments

@ggarnier
Copy link
Contributor

I just noticed the h1 tag is used not only in the page header (for the site title), but also in the posts title and sidebar titles (like "Related posts"). Shouldn't h1 be used only in the site title, and the other ones be replaced with h2?
@ttskch
Copy link
Owner

ttskch commented Dec 13, 2016

@ggarnier Thanks for your advice! I think you're right. In principle, we shouldn't use multiple h1 in one page. But at the same time I also think that both of SITE TITLE and POST TITLE are most important information appropriate for h1. I don't have the best idea for this problem... But at least, sidebar titles (like Related posts) have to be replaced with h2 I think 👍 Could you please some PR?

@ggarnier
Copy link
Contributor Author

@ttskch sure, I'll work on that

@ggarnier ggarnier mentioned this issue Feb 8, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change recent posts header tag to h2 ggarnier/jekyll-qck-theme
2 participants
@ggarnier @ttskch