Skip to content

Latest commit

 

History

History
37 lines (23 loc) · 1.3 KB

cran-comments.md

File metadata and controls

37 lines (23 loc) · 1.3 KB

Submission

This submission of trustedtimestamping (v0.2.6) provides two improvements:

  • better error-handling
  • Validation is done directly on horizon.stellar.org (to become less dependent on stellarapi.io)

Reported issues v0.2.5:

  • none (CRAN accepted)

Reported issues v0.2.4:

  • don't use print()
  • don't use T and F (use TRUE and FALSE)

Reported issues v0.2.3:

  • replace \dontrun{} by \donttest{} in your Rd-files if no API key is required.

Reaction: Replaced, no API key is required

  • ensure that your functions do not write by default or in your examples/vignettes/tests in the user's home filespace. E.g. create_ttsFile(file.path(tempdir(), "test.rds"))

Reaction: Functions don't write files. Timestamp is created through blockchain transaction, not by downloading some kind of certificate.

Reported issues v0.2.2:

Reported issues v0.2.1:

  • Title: please omit the redundant "R package for creating" and move the abbreviation (tts) to the Description field.
  • Description: Please omit the redundant " trustedtimestamping - R package for"
  • Description: Please make the latter a fully specified URL in the form <https......>.

R CMD check results

There were no ERRORs, WARNINGs or NOTES.