Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vercel deployment #1

Closed
ajnart opened this issue Sep 2, 2022 · 2 comments
Closed

Vercel deployment #1

ajnart opened this issue Sep 2, 2022 · 2 comments

Comments

@ajnart
Copy link

ajnart commented Sep 2, 2022

I'm looking forward to setting this up as my open notebook deployed on vercel.
For that I would need to hide keep my secrets locally while also having them on vercel.
This doesn't seem to be explained in the docs.

You should be able to set up a Deploy button
https://vercel.com/docs/deploy-button
with the correct API keys field and get a super simple deployment setup for new users

I've went ahead and made a deploy button already :
Deploy with Vercel

I would recommend you include it in the readme along with the "Run locally" section. I would open a PR but I'm on mobile at the moment

@ajnart
Copy link
Author

ajnart commented Sep 4, 2022

Nice ! I saw you just did that in your latest commit

@tuanphungcz
Copy link
Owner

@ajnart

yep! thanks for the deploy button, I forgot to ping you. 😄

I'm closing the issue then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants