Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Popup Card component #49

Closed
minhhang107 opened this issue Jan 19, 2022 · 2 comments
Closed

Build Popup Card component #49

minhhang107 opened this issue Jan 19, 2022 · 2 comments
Labels
feature Feature request frontend priority:low Default priority when a new issue is created
Projects
Seeksi
Milestone
Milestone 3

Comments

@minhhang107
Copy link
Collaborator

minhhang107 commented Jan 19, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.
Our app has lots of pop up dialogs so it'd be great to have a popup card component for reusability

Are there any related issues? Please list all of them.

Describe the solution you'd like

Acceptance criteria

  • The card can be resized to fit the content
  • The card is styled with appropriate margin
  • The card should contain X button at top right corner
  • The card should contain a title

Describe alternatives you've considered
Another option is to include the overlay in this component
Group 332

Inspiration here:
https://dev.to/g10dra/create-custom-popup-component-in-react-1o18

Additional context
Full mock-up design: https://www.figma.com/file/D6OdyoGg8cbL1hAScPEsYI/PRJ-Diagrams?node-id=402%3A736
@minhhang107 minhhang107 added frontend feature Feature request priority:low Default priority when a new issue is created labels Jan 19, 2022
@minhhang107 minhhang107 added this to the Milestone 3 milestone Jan 19, 2022
@minhhang107 minhhang107 added this to Backlog in Seeksi via automation Jan 19, 2022
@minhhang107 minhhang107 mentioned this issue Jan 19, 2022
Closed
@hlavu hlavu mentioned this issue Jan 19, 2022
Closed
@minhhang107
Copy link
Collaborator Author

@hlavu @mqnguyen5 do you guys think we need this?

@hlavu
Copy link
Collaborator

hlavu commented Feb 7, 2022

@hlavu @mqnguyen5 do you guys think we need this?

I think this is not necessary

Seeksi automation moved this from Backlog to Done Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Feature request frontend priority:low Default priority when a new issue is created
Projects
Seeksi
  
Done
Milestone
Milestone 3
Development

No branches or pull requests
2 participants
@hlavu @minhhang107