You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A string alteration component should not alter PHP settings--especially those put in place to protect a system from PHP overusing resources--but I realize the pragmatism in CSSmin choosing to do this by default.
I think this functionality should probably be moved to a component dedicated to sniffing and altering settings like these. I think at most CSSmin should keep the getSuggestedPhpLimits() method, or have those in a PHPDoc annotation that could be read through reflection.
Should run() return the settings to their original values before returning? Maybe the settings shouldn't be altered until run() is called... anyway, something to think about.
The text was updated successfully, but these errors were encountered:
I agree.
I've committed some changes right now although tomorrow I plan to further enhance the PHP settings since right now I'm forcing to set a specific amount of resources that in some environments may be even higher, so I'll add a check on that.
Users can override any setting (four public methods implemented)
Always prefer higher settings
Allow -1 for "no memory limit"
PHP settings are applied on each run() call
I agree PHP settings should be in a separate class but since this is a standalone class (my company uses it in different projects) we prefer to leave it as is although you may adapt (fork) the code to your needs for Minify ;)
A string alteration component should not alter PHP settings--especially those put in place to protect a system from PHP overusing resources--but I realize the pragmatism in CSSmin choosing to do this by default.
I think this functionality should probably be moved to a component dedicated to sniffing and altering settings like these. I think at most CSSmin should keep the getSuggestedPhpLimits() method, or have those in a PHPDoc annotation that could be read through reflection.
Should run() return the settings to their original values before returning? Maybe the settings shouldn't be altered until run() is called... anyway, something to think about.
The text was updated successfully, but these errors were encountered: