Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails without http:// in the TA IP settings field #5

Closed
p0358 opened this issue Aug 6, 2022 · 2 comments
Closed

Fails without http:// in the TA IP settings field #5

p0358 opened this issue Aug 6, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@p0358
Copy link

p0358 commented Aug 6, 2022

Little improvement suggestion, as the option in settings says "Tube Archivist IP", but if you indeed enter just the IP, it is going to fail (because it does not default to http protocol apparently?). I think the code should attempt to prepend http:// if no protocol is specified there already to avoid this, as it's not so obvious to figure out why it fails (if you check the logs and attempt to open the URL it tries to GET in a new tab, it will work...)

@p0358 p0358 changed the title Fails without http:// Fails without http:// in the TA IP settings field Aug 6, 2022
@bbilly1
Copy link
Member

bbilly1 commented Aug 8, 2022

It is mentioned in the Readme though: https://github.com/tubearchivist/browser-extension#setup.

But you are right, this could be added automatically when saving the form if needed.

Do you want to implement it? Please make a PR.

@bbilly1
Copy link
Member

bbilly1 commented Nov 30, 2022

This is now implemented in v0.1, defaulting to http://.

@bbilly1 bbilly1 closed this as completed Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants