Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using GTK3 Settings for font sizes #2

Closed
codeandcreate opened this issue Apr 10, 2021 · 6 comments · Fixed by #4
Closed

Using GTK3 Settings for font sizes #2

codeandcreate opened this issue Apr 10, 2021 · 6 comments · Fixed by #4
Labels
enhancement New feature or request

Comments

@codeandcreate
Copy link

Currently the base font sizes are hard coded; n * pango::SCALE.
It would be better to use the current GTK3 / session settings to scale the font based on user preferences.

@Schmiddiii
Copy link
Collaborator

I agree that this should probably not be hardcoded. The main problem I see is that this application uses two different font sizes (e.g. one for the video title and one for the channel). How should I handle the two different font sizes? Should I make it a fixed amount smaller than from the settings?

@Schmiddiii Schmiddiii added the enhancement New feature or request label Apr 10, 2021
@codeandcreate
Copy link
Author

i would successt to use something like n * 0.75 * pango::SCALE. for the smaller font... maybe with some rounding :)

@Schmiddiii
Copy link
Collaborator

I have implemented this feature in a new branch. Please check it out.
Note that you cannot change the font size using settings.ini on wayland. For more information look at the pull request.

@codeandcreate
Copy link
Author

Works for me! i use following code in .config/sway/config to set font size (...):

exec /usr/libexec/gsd-xsettings
exec lxpolkit
exec gsettings set org.gnome.desktop.interface font-name 'Inter Regular 15'
exec gsettings set org.gnome.desktop.interface monospace-font-name 'Hack Regular 15'

imho the small font is a little bit too small... but i'm using a fullhd screen with 12" and no scaling ;) so i think it is alright.
a little hint; add some spacing in feed_item.rs:
feed_item.rs_diff.txt

screenshot-2021-04-11-16-36-28

@Schmiddiii
Copy link
Collaborator

Added the spacing, thanks for the suggestion.
I am not that good with nice looking gui 🙂.

@codeandcreate
Copy link
Author

If you want i can help you with ui things when you will continue development :) just mail me anytime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants