[PR] Make some empty class and struct for interpretor #3
Conversation
| } | ||
|
|
||
| protocol PoseEstimator { | ||
| func predict(with pixelBuffer: CVPixelBuffer) -> PoseEstimationResult |
There was a problem hiding this comment.
In the imeplementation of protocol PoseEstimator,
behavior of predict is similar to estimate or inference.
So I think, 'estimate' or 'inference' are more suitable function name than 'predict'
There was a problem hiding this comment.
Thanks for your suggestion. I'll change to inference.
| @@ -9,12 +9,11 @@ | |||
| import UIKit | |||
|
|
|||
| class ViewController: UIViewController { | |||
|
|
|||
| let poseEstimator: PoseEstimator = PoseNetPoseEstimator() | |||
There was a problem hiding this comment.
What is the mean of NetPose?
There was a problem hiding this comment.
PoseNet is the paper for pose estimation distributed in 2015. PoseNetPoseEstimator stand for PoseNet + PoseEstimator which means that the pose estimator implementing PoseNet tflite model.
|
|
||
| import CoreVideo | ||
|
|
||
| enum PoseEstimationResult { |
There was a problem hiding this comment.
have you ever seen, https://developer.apple.com/documentation/swift/result ?
I think, you need to implement no fail case.
There was a problem hiding this comment.
Cool. Thanks for your advice.
| // <#TODO#> | ||
| } | ||
|
|
||
| var keypointsAndScore: [(position: CGPoint, score: CGFloat)] { |
There was a problem hiding this comment.
Keypoint have a score.
So, keypointsAndScore have duplicated meaning.
And I can implement, var keypoints: [Keypoint] { ... }.
This is more simple, isn't it?
There was a problem hiding this comment.
@syjdev
👍 Right, I replaced to keypoints: [Keypoints] property.
|
@syjdev |
Related Issue
PR Point
TFLiteImageInterpretorfor implementing pre-process of image inputPoseEstimatorprotocol for abstractionPoseNetPoseEstimatorfor specifying input/output and model name of PoseNet tflite file