Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Support lightweight cpm and hourglass #35

Merged
merged 61 commits into from Jun 17, 2020
Merged

Conversation

tucan9389
Copy link
Owner

@tucan9389 tucan9389 commented Jun 7, 2020

@tucan9389 tucan9389 self-assigned this Jun 7, 2020
@tucan9389
Copy link
Owner Author

@idchlife
Hi, I made a big PR. Could you please review the PR?
If you have any question, tell me feel free.
Thank you.

@idchlife
Copy link
Contributor

idchlife commented Jun 9, 2020

@tucan9389 code seems to be ok! Interesting thing that I also started working on moving all paths outside :D
It's good that you implemented this. Because of work I don't know when I would have time to finish my code

If code executes I think it would be nice to merge 👍

@tucan9389 tucan9389 mentioned this pull request Jun 9, 2020
5 tasks
Copy link

@canapio canapio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TEST for approving

@tucan9389 tucan9389 merged commit 5fd8c97 into master Jun 17, 2020
@tucan9389 tucan9389 deleted the new-model/mv2_cpm branch June 17, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants