Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproducing results from the article, issue with runtimes.csv #9

Closed
OnniMansikkamaki opened this issue Mar 28, 2022 · 3 comments
Closed

Comments

@OnniMansikkamaki
Copy link

Hello! I am trying to reproduce results from the article, and I can't figure out certain problem. First I am trying to run train_kfold_models, but the code always ouputs an error: "ImportError: cannot import name 'GrootTree' from 'groot.model'". Is there something wrong with the .py file I am trying to run, or is this problem something that doesn't occur to you and everyone else (-->something wrong on computer or files or environment)?

Onni Mansikkamäki

@daniel-vos
Copy link
Contributor

Hello, thanks for the question! This is my mistake, the experiment code in (e.g. train_kfold_models.py) is outdated. For example, I changed GrootTree to GrootTreeClassifier some time ago to better align with Scikit-learn.

To separate the experiment code from GROOT's source code I have created an updated repository here: https://github.com/tudelft-cda-lab/GROOT-experiment-code . Could you check if the problem still persists there?

Thanks for your interest!

@daniel-vos
Copy link
Contributor

Hi, did you get a chance to test the experiment code? @OnniMansikkamaki

@OnniMansikkamaki
Copy link
Author

Hello,
Works perfectly for me, thank you very much for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants