-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port to ESM #388
Comments
Thank you @bbhtt for letting me know. Is this only about replacing the dependencies with And how can we test this before 45 is released? |
Probably. 45.beta is out and I think it includes the changes. I can't comment too much on the code changes as I'm not following it that closely but feel free to drop by in #extensions:gnome.org (Matrix) that's where extensions/shell experts are in, GNOME discourse etc. |
There's a guide at https://gjs.guide/extensions/upgrading/gnome-shell-45.html#esm |
Thank you @alephnull |
I've migrated the extension to GNOME 45, would greatly appreciate testing & bug reports 🙏 |
Awesome ❤️ Seems to work. Will report anything if I see. |
GNOME Shell switched to ESM as part of 45 https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1499. This means all extensions will be broken unless ported.
See the GUADEC talk: https://youtu.be/qaZuQO0bK-M?t=21013
The official ones have already been ported https://gitlab.gnome.org/GNOME/gnome-shell-extensions/-/commit/a9114473751fd022a5208618a8c9bb488651a48a
This breaks backwards compat in a way: https://gjs.guide/extensions/upgrading/gnome-shell-45.html#shell-version
You'll have to upload multiple versions (if it is ported) to target older GNOME versions.
The text was updated successfully, but these errors were encountered: