Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to ESM #388

Closed
bbhtt opened this issue Aug 13, 2023 · 6 comments
Closed

Port to ESM #388

bbhtt opened this issue Aug 13, 2023 · 6 comments

Comments

@bbhtt
Copy link

bbhtt commented Aug 13, 2023

GNOME Shell switched to ESM as part of 45 https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1499. This means all extensions will be broken unless ported.

See the GUADEC talk: https://youtu.be/qaZuQO0bK-M?t=21013

The official ones have already been ported https://gitlab.gnome.org/GNOME/gnome-shell-extensions/-/commit/a9114473751fd022a5208618a8c9bb488651a48a

This breaks backwards compat in a way: https://gjs.guide/extensions/upgrading/gnome-shell-45.html#shell-version

You'll have to upload multiple versions (if it is ported) to target older GNOME versions.

@Tudmotu
Copy link
Owner

Tudmotu commented Aug 14, 2023

Thank you @bbhtt for letting me know.

Is this only about replacing the dependencies with import * as ... from '...' or is there anything else that needs changing?

And how can we test this before 45 is released?

@bbhtt
Copy link
Author

bbhtt commented Aug 14, 2023

Thank you @bbhtt for letting me know.

Is this only about replacing the dependencies with import * as ... from '...' or is there anything else that needs changing?

And how can we test this before 45 is released?

Probably.

45.beta is out and I think it includes the changes.

I can't comment too much on the code changes as I'm not following it that closely but feel free to drop by in #extensions:gnome.org (Matrix) that's where extensions/shell experts are in, GNOME discourse etc.

@alephnull
Copy link

@Tudmotu
Copy link
Owner

Tudmotu commented Sep 5, 2023

Thank you @alephnull

@Tudmotu
Copy link
Owner

Tudmotu commented Sep 10, 2023

I've migrated the extension to GNOME 45, would greatly appreciate testing & bug reports 🙏
You can try it on GNOME 45.beta by cloning the gnome45 branch:
https://github.com/Tudmotu/gnome-shell-extension-clipboard-indicator/tree/gnome45

@Tudmotu Tudmotu closed this as completed Sep 10, 2023
@bbhtt
Copy link
Author

bbhtt commented Sep 10, 2023

Awesome ❤️

Seems to work. Will report anything if I see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants