Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doesnt seem to work with gnome 45 beta #395

Closed
hrdkmishra opened this issue Sep 15, 2023 · 24 comments
Closed

doesnt seem to work with gnome 45 beta #395

hrdkmishra opened this issue Sep 15, 2023 · 24 comments

Comments

@hrdkmishra
Copy link

image

i downloaded via gnome extension

@Tudmotu
Copy link
Owner

Tudmotu commented Sep 15, 2023

Thank you for testing this out! 🙏

Would you mind please running the following in your terminal (preferably right after a login) and see if you can find the error there, with the filename and line of the exception?

$ journalctl -f /usr/bin/gnome-shell

Thanks!

Edit:
Tried to reproduce it but for me it seems to work.

  1. What distro are you on?
  2. What gnome-shell version exactly? (gnome-shell --version)
  3. Did you set anything in the settings?

image

@schlagmichdoch
Copy link

Can confirm this works on GNOME Shell 45.rc since updating a few days ago.

@Tudmotu
Copy link
Owner

Tudmotu commented Sep 15, 2023

Thank you @schlagmichdoch . Did you install it from extensions.gnome.org or from Git?

@schlagmichdoch
Copy link

from extensions.gnome.org

@Tudmotu
Copy link
Owner

Tudmotu commented Sep 15, 2023

Got it. Thank you! 🙏

@wuqso
Copy link

wuqso commented Sep 17, 2023

image

i downloaded via gnome extension

I have the same problem. I'm using Fedora 39 prerelease and gnome shell 45.rc. I installed this extension from extensions.gnome.org and can see all settings.

@wuqso
Copy link

wuqso commented Sep 17, 2023

The error is there when running

$ journalctl -f /usr/bin/gnome-shell

@Tudmotu
Copy link
Owner

Tudmotu commented Sep 17, 2023

@wuqso can you please share the error message, filename, line number and stack trace?

@Valeryan24
Copy link

Valeryan24 commented Sep 17, 2023

Hi, same error message here :
Ubuntu 23.10 beta
GNOME Shell 45.rc
Clipboard Indicator 51 (installed from Gnome extensions site)

journalctl -f /usr/bin/gnome-shell
sept. 17 14:49:43 valeryan24-desktop gnome-shell[2739]: Meta.Rectangle is deprecated, use Mtk.Rectangle instead
sept. 17 14:49:43 valeryan24-desktop gnome-shell[2739]: Meta.Rectangle is deprecated, use Mtk.Rectangle instead
sept. 17 14:49:43 valeryan24-desktop gnome-shell[2739]: Meta.Rectangle is deprecated, use Mtk.Rectangle instead
sept. 17 14:49:45 valeryan24-desktop gnome-shell[2739]: Meta.Rectangle is deprecated, use Mtk.Rectangle instead
sept. 17 14:49:46 valeryan24-desktop gnome-shell[2739]: Meta.Rectangle is deprecated, use Mtk.Rectangle instead
sept. 17 14:49:47 valeryan24-desktop gnome-shell[2739]: Meta.Rectangle is deprecated, use Mtk.Rectangle instead
sept. 17 14:49:50 valeryan24-desktop gnome-shell[2739]: Meta.Rectangle is deprecated, use Mtk.Rectangle instead
sept. 17 14:49:52 valeryan24-desktop gnome-shell[2739]: Meta.Rectangle is deprecated, use Mtk.Rectangle instead
sept. 17 14:49:53 valeryan24-desktop gnome-shell[2739]: Meta.Rectangle is deprecated, use Mtk.Rectangle instead
sept. 17 14:49:53 valeryan24-desktop gnome-shell[2739]: meta_window_set_stack_position_no_sync: assertion 'window->stack_position >= 0' failed

No extension settings changed.

@Tudmotu
Copy link
Owner

Tudmotu commented Sep 17, 2023

Thank you all. There is indeed an issue on GNOME 45.0, which does not exist on 45.beta.1.

Working on fixing it now.

@Tudmotu
Copy link
Owner

Tudmotu commented Sep 17, 2023

@wuqso @hrdkmishra @Valeryan24 Thank you all for reporting this!
I've uploaded a new version to e.g.o.
Would really appreciate if you could install v52 and let me know if the extension works 🙏

@Valeryan24
Copy link

Version 52 works well for me on Ubuntu and Gnome 45.rc, thanks for the quick upgrade !

@Tudmotu
Copy link
Owner

Tudmotu commented Sep 17, 2023

Thank you for testing it out @Valeryan24 🙏

@rmader
Copy link
Contributor

rmader commented Sep 17, 2023

Hi - while version 52 mostly works for me, opening the settings is still broken with the following message:

The settings of extension clipboard-indicator@tudmotu.com had an error:

TypeError: (intermediate value).SpinRow is not a constructor

Stack trace:

Settings@file:///home/robert/.local/share/gnome-shell/extensions/clipboard-indicator@tudmotu.com/prefs.js:27:27
fillPreferencesWindow@file:///home/robert/.local/share/gnome-shell/extensions/clipboard-indicator@tudmotu.com/prefs.js:12:28
_loadPrefs@resource:///org/gnome/Shell/Extensions/js/extensionPrefsDialog.js:36:18
async*_init@resource:///org/gnome/Shell/Extensions/js/extensionPrefsDialog.js:21:14
ExtensionPrefsDialog@resource:///org/gnome/Shell/Extensions/js/extensionPrefsDialog.js:12:4
OpenExtensionPrefsAsync@resource:///org/gnome/Shell/Extensions/js/extensionsService.js:139:33
async*_handleMethodCall@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:373:35
_wrapJSObject/<@resource:///org/gnome/gjs/modules/core/overrides/Gio.js:408:34
_init/GLib.MainLoop.prototype.runAsync/</<@resource:///org/gnome/gjs/modules/core/overrides/GLib.js:266:34

@Tudmotu
Copy link
Owner

Tudmotu commented Sep 18, 2023

Thanks for reporting @rmader. I can't reproduce this but I will look into it.
Can you please tell me the exact version of GNOME you are running? (gnome-shell --version)
Also if this a fresh install, or did you upgrade Clipboard Indicator from an older version?

@rmader
Copy link
Contributor

rmader commented Sep 18, 2023

Sorry, my bad. SpinRow is a libadwaita 1.4 feature which I didn't have on my system yet - and while it's not required by GS 45, it's practically part of the Gnome 45 release. After updating that the settings work again.

@Tudmotu
Copy link
Owner

Tudmotu commented Sep 18, 2023

@rmader thank you for the update! Glad to hear it works now 🙂

@wuqso
Copy link

wuqso commented Sep 18, 2023

The new version works but the clipboard is always empty. What's the problem?

@Tudmotu
Copy link
Owner

Tudmotu commented Sep 18, 2023

@wuqso Do you see any errors in journalctl /usr/bin/gnome-shell?
Also does pasting not work either?

@wuqso
Copy link

wuqso commented Sep 18, 2023

All errors are libinput errors. Pasting works fine with the middle button of the mouse.

@wuqso
Copy link

wuqso commented Sep 18, 2023

The clipboard is also always empty in the extension 'clipman' on my system. Do I need any extra apps?

@Tudmotu
Copy link
Owner

Tudmotu commented Sep 18, 2023

@wuqso ctrl+v doesn't paste?
Does it work when you disable all extensions?

@wuqso
Copy link

wuqso commented Sep 19, 2023

After some trials, I found I need to use the right button of the mouse to 'copy' the text into the clipboard. I would prefer to copy the text into the clipboard by just highlighting the text.

@Tudmotu
Copy link
Owner

Tudmotu commented Sep 19, 2023

@wuqso yes this is one of the oldest and most requested features for this extension: #8
I might try to implement it some when soon. Now that we had to drop support for older versions, it should be easier.
If anyone else would like to give it a stab, I'll happily merge a PR. If anyone is interested please reach out to me via email and I'll explain how it should probably work. It won't be simple though.

@Tudmotu Tudmotu closed this as completed Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants