Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Git tags #402

Closed
lubo opened this issue Oct 13, 2023 · 9 comments
Closed

Missing Git tags #402

lubo opened this issue Oct 13, 2023 · 9 comments

Comments

@lubo
Copy link

lubo commented Oct 13, 2023

Clipboard Indicator - GNOME Shell Extensions states that versions 50 and later exist, yet the last tag in Git is v47. Please, add the missing tags.

@Tudmotu
Copy link
Owner

Tudmotu commented Oct 13, 2023

The problem is the latest version, which supports GNOME 45, completely breaks backwards compatibility, and since most distributions don't have GNOME 45 yet, the extension would break for them. So I am waiting until 45.1 is released (which is when most distros should add the new GNOME version).

I will merge the gnome45 branch to master and will create tags once it's out.

For now, if you are a package maintainer, you can use the gnome45 branch, assuming the distro you are packaging for has GNOME 45 already.

@lubo
Copy link
Author

lubo commented Oct 13, 2023

Sorry, but I don't understand what prevents you from tagging. Tagged commits don't have to be in the main branch. The versions exist, they are published and we should be able to tell to which versions they correspond. Do you wanna do rebase or something similar? I'd say that's not advisable at this point, since you've already published existing revisions.

@Tudmotu
Copy link
Owner

Tudmotu commented Oct 15, 2023

This is a very popular GNOME extension. It is packaged by many contributors to many different distros. I am not aware of all the different packages, but I know some of them automatically fetch the latest tag without manually testing. If you accidentally install the new version on a distro that does not support GNOME 45, it will break. When this extension breaks, I tend to get many, many emails. So I am taking the safe route.
GNOEM 45.1 should be out in 1-2 weeks, so I will tag it then.

@jonian
Copy link

jonian commented Oct 18, 2023

The missing tags for gnome 45 have resulted in broken arch linux (AUR) package. I agree that tags/releases should be created when they are released. Package maintainers should take care when they have to update their package version. That should not be any of your concerns. Just my opinion.

@Tudmotu
Copy link
Owner

Tudmotu commented Oct 19, 2023

@jonian Thank you for letting me know. I was not aware Arch already upgraded to GNOME 45, they usually wait until 4X.1.

@Tudmotu
Copy link
Owner

Tudmotu commented Oct 19, 2023

Ok I see Ubuntu has also already released GNOME 45.
The main one that still doesn't support it is Fedora, but from what I can tell they should release any time now.
I will do a quick check what other distros already support 45.

@Tudmotu
Copy link
Owner

Tudmotu commented Oct 19, 2023

Ok looking at https://repology.org/project/gnome-shell/versions
It seems all major distributions already support 45.0.

Thank you @jonian and @lubo, I will tag the releases now and will not wait for 45.1.

@Tudmotu
Copy link
Owner

Tudmotu commented Oct 19, 2023

I tagged v54.
https://github.com/Tudmotu/gnome-shell-extension-clipboard-indicator/tree/v54

@Tudmotu Tudmotu closed this as completed Oct 19, 2023
@jonian
Copy link

jonian commented Oct 19, 2023

Thanks @Tudmotu! I updated the AUR package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants