Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: When I type a search query and press tab once/twice, the blank spots after the search bar are focused. #78

Closed
schokotets opened this issue Nov 6, 2021 · 2 comments · Fixed by #79
Closed

[BUG]: When I type a search query and press tab once/twice, the blank spots after the search bar are focused. #78

schokotets opened this issue Nov 6, 2021 · 2 comments · Fixed by #79

Comments

@schokotets
Copy link
Contributor

schokotets commented Nov 6, 2021 •
edited
Loading

Context
I haven't selected a "FSR" in the dropdown on the right side.

What is the bug?
When I type a search query in the extension window and press tab once/twice, the blank spots after the search bar are focused. The elements that get highlighted are #fsr_link_2 and #fsr_link.

What's expected behavior?
I would expect the selection to jump to the first search result after one, not three Tab presses.

Screenshots
before pressing Tab:
image

after pressing Tab once:
image

after pressing Tab another time:
image

What system are you running?

  • What browser?
    • Brave 1.30.87 Chromium: 94.0.4606.71 (Official Build) (64-bit)
  • What version of TUfast?
    • 6.0.0.3

Suggestions on how to fix:

  • set display: none style on the #fsr_link and #fsr_link_2 anchors if no FSR is selected
  • set tabindex="-1" attribute on the #fsr_link and #fsr_link_2 anchors
    • avoid for accessibility reasons
schokotets added a commit to schokotets/TUfast_TUD that referenced this issue Nov 6, 2021
@schokotets
Hide fsr links if no FSR is selected TUfast-TUD#78
9288750
@schokotets
Copy link
Contributor Author

I'd call this a hotfix, which is why I committed to main. Sorry I haven't talked to you before writing code. Perhaps you can get this pulled soon.

schokotets added a commit to schokotets/TUfast_TUD that referenced this issue Nov 6, 2021
@schokotets
Unhide fsr links once an FSR is selected TUfast-TUD#78
5494b0a
@schokotets schokotets mentioned this issue Nov 6, 2021
Merged
9 tasks
schokotets added a commit to schokotets/TUfast_TUD that referenced this issue Nov 6, 2021
@schokotets
Remove fsr_link stub when no FSR is set TUfast-TUD#78
de53b5c
@OliEfr OliEfr linked a pull request Nov 6, 2021 that will close this issue
Hide #fsr_link and #fsr_link_2 if no FSR is selected #79
Merged
9 tasks
@OliEfr
Copy link
Member

OliEfr commented Nov 6, 2021

Hi,

thanks for the report! Implementation is also fine. Yes, I agree its a hotfix. I will go ahead and merge this right away.
Release-wise I cant tell when it gets published exactly - should be done in the following week.

Thinking about it, I would go even further and say that you want to tab to your courses directly without focusing the fsr_link
in between. But thats only a minor thought and not relevant for this PR.

@OliEfr OliEfr closed this as completed in #79 Nov 6, 2021
OliEfr pushed a commit that referenced this issue Nov 6, 2021
@schokotets
Hide #fsr_link and #fsr_link_2 if no FSR is selected (#79)
af61753 
* Hide fsr links if no FSR is selected #78

* Unhide fsr links once an FSR is selected #78

* Remove fsr_link stub when no FSR is set #78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hide #fsr_link and #fsr_link_2 if no FSR is selected schokotets/TUfast_TUD
2 participants
@schokotets @OliEfr