Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YAML/JSON field name typo: "reuired" -> "required" #492

Closed
raphaelhuefner opened this issue Feb 12, 2024 · 1 comment
Closed

YAML/JSON field name typo: "reuired" -> "required" #492

raphaelhuefner opened this issue Feb 12, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@raphaelhuefner
Copy link
Contributor

Describe the bug
When listing all checks in YAML or JSON format, a "reuired" field shows up, which is clearly a typo of the intended "required".

To Reproduce
Steps to reproduce the behavior:

  1. Run oasdiff checks --format yaml or oasdiff checks --format json
  2. Output: all entries have a "reuired" boolean field

Expected behavior

  • All entries have a "required" boolean field.
  • No entry has a "reuired" boolean field.

Desktop (please complete the following information):

  • OS: macOS
  • installed via go install github.com/tufin/oasdiff@v1

Additional context

I suggested this PR to fix the typo: #491

@raphaelhuefner raphaelhuefner added the bug Something isn't working label Feb 12, 2024
@tcdsv
Copy link
Collaborator

tcdsv commented Feb 13, 2024

thanks for the typo report and PR fix.

@tcdsv tcdsv closed this as completed Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants