Performance improvement: cache build phase for build files #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Danger run resulted in 2 messages and 2 warnings; to find out more, see the checks page. Generated by 馃毇 dangerJS |
|
The changelog for this is in #338 |
yonaskolb
commented
Oct 11, 2018
| let projectObjects = try objects() | ||
| switch type { | ||
| case .copyFiles?: | ||
| return projectObjects.copyFilesBuildPhases |
There was a problem hiding this comment.
This also removes the double loop of copy build phase files, even if there wasn't a cache
|
@pepibumur is this good to merge? |
pepicrft
approved these changes
Oct 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves performance when writing build files by caching the build phase they belong to.
On one test it halved the writing time. The more build files in a project the bigger the gain 馃憤