Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parallelizable and randomly ordered tests support #340

Merged
merged 1 commit into from Oct 12, 2018

Conversation

alvarhansen
Copy link
Contributor

Resolves #335

Short description πŸ“

Adds parallelizable and randomly ordered tests support

Solution πŸ“¦

Adds parallelizable: Bool randomExecutionOrdering: Bool properties to TestableReference

Implementation πŸ‘©β€πŸ’»πŸ‘¨β€πŸ’»

Added tests to make sure default old schema files won't be affected by making sure default values are not written.

@yonaskolb
Copy link
Collaborator

Fantastic, thanks @alvarhansen! Could you check that the default alphabetical order is what Xcode uses when writing the scheme. Entries may potentially have to be added here https://github.com/tuist/xcodeproj/blob/master/Sources/xcodeproj/Extensions/AEXML%2BXcodeFormat.swift#L31

Could you also add a changelog entry

@alvarhansen
Copy link
Contributor Author

@yonaskolb, turns out the ordering was not alphabetical. I added the order to XcodeFormat.swift.
Also updated the changelog.

@yonaskolb
Copy link
Collaborator

Awesome, great work!

@yonaskolb yonaskolb merged commit 80a8545 into tuist:master Oct 12, 2018
@ghost
Copy link

ghost commented Oct 12, 2018

Danger run resulted in 2 messages; to find out more, see the checks page.

Generated by 🚫 dangerJS

@pepicrft
Copy link
Contributor

Thanks for adding this @alvarhansen πŸ‘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants