Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate playsound module #49

Closed
not-nef opened this issue Jan 18, 2022 · 7 comments
Closed

Integrate playsound module #49

not-nef opened this issue Jan 18, 2022 · 7 comments

Comments

@not-nef
Copy link

not-nef commented Jan 18, 2022

No description provided.

@insolor
Copy link

insolor commented Jan 18, 2022

Why is it needed to be integrated into tukaan itself? Just run playsound asynchronously (with the second parameter set to False, as suggested in the playsound's readme), this way it will not block the main thread.

@not-nef
Copy link
Author

not-nef commented Jan 18, 2022

Well i just thought it would be useful

@insolor
Copy link

insolor commented Jan 19, 2022

Maybe, if you specify what kind of integration do you mean, it would be clearer. From my perspective, it is easy to use playsound as is, as a separate package, without any additional integration.

As an example, what needs some kind of integration is pystray, because there is no clear and obvious way how to add a tray icon when you use tkinter or tukaan. There is some workaround on StackOverflow, but as far as I remember I had some problems with this approach on Linux.

@rdbende
Copy link
Member

rdbende commented Mar 11, 2022

Well, I'm not going to integrate the playsound module, for several reasons.

  1. playsound has only one function, which isn't a big deal to import from there instead of Tukaan
  2. playsound advertises itself as no dependencies required, which is not true. On Linux you need the PyGObject package, which is a huge dependency
  3. playsound is dumb. It has only one function, which doesn't allow you to stop the music, edit it, or do anything useful with it.
  4. I have a MUCH better idea for sound support in Tukaan

@rdbende rdbende closed this as completed Mar 11, 2022
@rdbende
Copy link
Member

rdbende commented Mar 11, 2022

@insolor I'm not sure in Pystray either.
It's a pain to get it working with Tkinter, since both have their own mainloops that block each other.

I might just implement the tk systray feature that's in Tk 8.7, although it would be nice to find a way to make Tukaan and Pystray work well together.

@sumeshir26
Copy link

But mac dosent have Tcl 8.7 unless you use annaconda, right?

@rdbende
Copy link
Member

rdbende commented Mar 11, 2022

I won't add support for Tcl/Tk 8.7 until they release the stable version, so I don't think that's a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants