UnitFrames fader does not respect correct distance to target

[WiredUK]

Troubleshooting Steps

Note the target unitframe is faded out despite me being 25-30 yards from the target. I can take a step closer and it will fade back in again. I have installed RangeDisplay addon to show the range, shown just above the target unitframe in the screenshot, hope that helps.

Not sure if relevant, but I have the new Phantom Reach priest talent to increase range by 15% so I am within range at ~45 feet.

Describe the expected behavior and what actually happened?

When the range setting for fader on the target UnitFrame, the range is not accurate as to when it fades out. Note the distance doesn't seem to be consistent either. Very limited testing seems to indicate the physical size of the mob might play a factor, the larger the mob, the closer I need to be to unfade the frame, but that could be a red herring.

Reproducing the issue.

No response

Lua Errors

No response

Verification Steps

• I have read the Changelog and verified ElvUI is up to date by checking /estatus
• I have verified my issue doesn't exist in the Default UI or the Issue Tracker.
• I have not read any of these steps, please close my issue when you see it.
• I have done the Troubleshooting Steps and included the requested screenshots, which show the issue and status panel.

[kodewdle]

post talent page

[WiredUK]

@kodewdle This is my talent build:

CIQAJSbRac/22NxZbHdYKOQzcMwYGDAAAAAAAAAAAAwMsNGzYWmNmZmZ2mZmF4B2YmZmxsxAjxMmFz2UzMYBmBAAAAAA

[HerrNirmas]

Same for Hunter Range seem 10m to short

[WiredUK]

@HerrNirmas Yes, same on my hunter too. Also confirmed on a warlock and a MoP Remix druid.

[WiredUK]

I think I have figured out the problem. In ElvUI_Libraries/Core/LibRangeCheck-3.0/LibRangeCheck on line 86 we have this line:

local GetSpellBookItemName = _G.GetSpellBookItemName or function(index, bookType)

If I change it to be this, the range check works:

local GetSpellBookItemName = function(index, bookType)

So it seems as if something else is setting up _G.GetSpellBookItemName to do something different.

Also, the official repo for LibRangeCheck seems to have some very different code in there now, so perhaps this is as simple as updating to the latest version.

EDIT: I can confirm that replacing the local lib with the version from the original, minor version 21, (and renaming to "LibRangeCheck-3.0-ElvUI" of course) also fixes this problem too.

[kodewdle]

Thanks @WiredUK we actually have a fork of thiers, there was an update to theirs again (WeakAuras/LibRangeCheck-3.0@7c73357) which we accounted for (ed65ca4) and fixed a bug in dev (a888856). please retry and report back :)

dev version: elvui-main.zip

[WiredUK]

dev version: elvui-main.zip

Works great, thanks @kodewdle

[kodewdle]

fixed in 13.73