Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension no longer works in Chrome dev channel #340

Open
RandTrawick opened this issue Sep 12, 2023 · 12 comments
Open

Extension no longer works in Chrome dev channel #340

RandTrawick opened this issue Sep 12, 2023 · 12 comments

Comments

@RandTrawick
Copy link

RandTrawick commented Sep 12, 2023

The extension no longer works in chrome canary or dev channels.
This could be a sign that it will break in future chrome release.
Still works in the chrome prod release channel for now.
Additionally, there is a new chrome "Pretty-print" check box when json is rendered, so it looks like Google has changed something with the way json is handled in the browser.
It's probably worth investigating why it is breaking in the dev channel.

förhoppningsvis går det att fixa.

@escot
Copy link

escot commented Sep 13, 2023

Version 117.0.5938.63 (Official Build) (64-bit) - extension does not work anymore.

@ahernandezq
Copy link

ahernandezq commented Sep 13, 2023

Seems like google chrome has added "pretty print" feature which overrides this extension behavior

@asrorbekh
Copy link

Not working on this version of chrome: Version 117.0.5938.62 (Official Build) (64-bit)

@kenneth-bro
Copy link

how to work?

@eternalblue
Copy link

Seems like google chrome has added "pretty print" feature which overrides this extension behavior

other extensions work, in a weird way still displaying the "pretty print" of new chrome but work at least

@bukowskiadam
Copy link

It does not work with the latest Chrome release.
I think the problem is here:

var childNode = childNodes[0];

Extension tries to get the first child from body, but now the first child is DIV
image
image

@RandTrawick
Copy link
Author

Nice find @bukowskiadam.

On another note, I checked the chrome flags yesterday and I didn't see an option to turn the default json viewer off like exists in edge, maybe someone else will have better luck checking.

@tulios
Copy link
Owner

tulios commented Sep 15, 2023

Thanks for reporting. I will take a look this weekend

@gg-hsi
Copy link

gg-hsi commented Sep 30, 2023

issue solved on Chrome 117.0.5938.132 .

@asrorbekh
Copy link

issue solved on Chrome 117.0.5938.132 .

Could you show as example screenshot?

@gg-hsi
Copy link

gg-hsi commented Sep 30, 2023

issue solved on Chrome 117.0.5938.132 .

Could you show as example screenshot?

There you go
http://baike.baidu.com/api/openapi/BaikeLemmaCardApi?scope=103&format=json&appid=379020&bk_key=%E5%85%B3%E9%94%AE%E5%AD%97&bk_length=600
image

@asrorbekh
Copy link

issue solved on Chrome 117.0.5938.132 .

Could you show as example screenshot?

There you go http://baike.baidu.com/api/openapi/BaikeLemmaCardApi?scope=103&format=json&appid=379020&bk_key=%E5%85%B3%E9%94%AE%E5%AD%97&bk_length=600 image

Thanks! It worked for me too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants