We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Describe the bug The Typescript interface is defined as:
saslAuthenticate: <ParseResult>( request: SaslAuthenticationRequest, response?: SaslAuthenticationResponse<ParseResult> ) => Promise<ParseResult | void>
While the implementation expects a single arg that is a wrapper object with request and response properties: https://github.com/tulios/kafkajs/blob/master/src/broker/saslAuthenticator/index.js#L42
request
response
Expected behavior The TS interface should match the implementation
Observed behavior Implementing a custom SASL mechanism to the TS interface will result in an error at runtime due to the unexpected shape of the arg.
The text was updated successfully, but these errors were encountered:
Much appreciated for the fast turnaround 🙏
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
Describe the bug
The Typescript interface is defined as:
While the implementation expects a single arg that is a wrapper object with
request
andresponse
properties: https://github.com/tulios/kafkajs/blob/master/src/broker/saslAuthenticator/index.js#L42Expected behavior
The TS interface should match the implementation
Observed behavior
Implementing a custom SASL mechanism to the TS interface will result in an error at runtime due to the unexpected shape of the arg.
The text was updated successfully, but these errors were encountered: