Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maxInFlightRequests documented in the wrong place #753

Closed
Nevon opened this issue Jun 9, 2020 · 2 comments
Closed

maxInFlightRequests documented in the wrong place #753

Nevon opened this issue Jun 9, 2020 · 2 comments
Labels
documentation good first issue

Comments

@Nevon
Copy link
Collaborator

Nevon commented Jun 9, 2020

Describe the bug
Currently maxInFlightRequests is documented as being an option for retry, when it's actually a top-level option for the consumer and producer factory functions.

To Reproduce

https://kafka.js.org/docs/configuration#a-name-retry-a-default-retry

Expected behavior

The option should be removed from the retry documentation and added to the consumer & producer.
@sujay-neglur
Copy link
Contributor

#754

@Nevon
Copy link
Collaborator Author

Nevon commented Jun 10, 2020

Closed by #754

@Nevon Nevon closed this as completed Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Nevon @sujay-neglur