Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Create a plumber setting instead of hard-coding xdg-open #433

Open
AlexBocken opened this issue Jul 13, 2023 · 5 comments

Comments

@AlexBocken
Copy link

Personally I've always been a large fan of using rifle instead of xdg-open when possible.
Could maybe a setting be implemented where one could set the plumber instead of xdg-open being hard-coded?

Maybe I can take a look and patch together a PR in the coming day if it is wanted.

@goodboy
Copy link

goodboy commented Jul 13, 2023

Woo i love this and it pertains to what i'm still planning to finish in #422 😎

Another launcher that might be worth thinking about (if we wanted to generalize) is https://github.com/chmln/handlr which I've been meaning to give a serious try 🏄🏼

@AlexBocken
Copy link
Author

Is that what your last point in the original comment of #422 pertains to? (Btw, really looking forward to that one being merged)

it'd be suuuper slick if we could use ranger for opening media files as well - eg. when clicking an inline image?

I wasn't sure whether that's the same idea. I must admit I'm not too familiar with the code base and/or Go, so if you think it's quick for you to implement and are open to do it please go ahead.
The basic idea is just to replace "xdg-open" in

https://github.com/tulir/gomuks/blob/09a927955810f6f0c6d3f4809d9b01eda365fd39/lib/open/open_xdg.go#L5C1-L5C27

WIth a user-settable string.

@goodboy
Copy link

goodboy commented Jul 13, 2023

(Btw, really looking forward to that one being merged)

Yeah, sorry just been totally derailed by a new distro and how to get stuff working and setup for dev in golang again.
I'm definitely looking forward to it too 😂

I wasn't sure whether that's the same idea. I must admit I'm not too familiar with the code base and/or Go, so if you think it's quick for you to implement and are open to do it please go ahead.

I just think it's somewhat related in the sense that choosing a program for file-dialogs is more or less related to xdg-open portals (at least afaiu) and thus i think what you're more or less asking for is pluggable xdg-portal backends?


I have the following resources on my learning list for all this:

@goodboy
Copy link

goodboy commented Jul 13, 2023

@AlexBocken oh also not sure if you're in the matrix room but we can discuss in their as well if you want 😉

@TamasBarta
Copy link

Hello! This feature would be especially amazing for macOS users, since we have open here, and open cannot recognize file headers, only file extensions, so by default it tries to open everything in some default text editor, that I didn't even know existed. (That could be a separate issue to append a proper file extension to the temporary files' names.) Also I believe open will never support to open a file in the same terminal, and wait for its completion, which also would be amazing for opening files in terminal tools.

(I miss Linux so much 😢)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants