Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use upstream tcell? #10

Open
n-peugnet opened this issue Jul 1, 2023 · 4 comments · May be fixed by #12
Open

Use upstream tcell? #10

n-peugnet opened this issue Jul 1, 2023 · 4 comments · May be fixed by #12

Comments

@n-peugnet
Copy link
Contributor

From what I see in the diffs, the only meaningful changes remaining in the fork is tulir/tcell@11b8e48. Wouldn't be a good idea to try to upstream this commit and use the upstream version of tcell afterwards ?

I can make the changes and the pull request to tcell if you are ok with this, or maybe there is another reason why you prefer keeping a fork of tcell ?
@tulir
Copy link
Owner

tulir commented Jul 1, 2023

gdamore/tcell#622 / gdamore/tcell#97

@nileshpatra
Copy link

According to gdamore/tcell author, ButtonNone is enough to indicate drags. I haven't read through mauview code - do you find it a possibility to fix the code with this hint?

@nileshpatra
Copy link

@tulir ping?

@tulir
Copy link
Owner

tulir commented Feb 18, 2024

It's probably possible to use upstream, but requires refactoring the drag detection to remember previous buttons, so not currently planned

@n-peugnet n-peugnet mentioned this issue Feb 18, 2024
Merged
@n-peugnet n-peugnet linked a pull request Mar 21, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use upstream tcell n-peugnet/mauview
3 participants
@tulir @n-peugnet @nileshpatra