Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI job does not fail on errors #4

Closed
Bai-Yingjie opened this issue Oct 18, 2022 · 1 comment · Fixed by #5
Closed

CI job does not fail on errors #4

Bai-Yingjie opened this issue Oct 18, 2022 · 1 comment · Fixed by #5

Comments

@Bai-Yingjie
Copy link

Hi,
I am using pubish-gitbook action in my repo:

# A workflow run is made up of one or more jobs that can run sequentially or in parallel
jobs:
  # This workflow contains a single job called "deploy"
  deploy:
    # The type of runner that the job will run on
    runs-on: ubuntu-latest

    # Steps represent a sequence of tasks that will be executed as part of the job
    steps:
      # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
      - name: Checkout
        uses: actions/checkout@v3
      
      - name: Publish Gitbook
        uses: tuliren/publish-gitbook@master
        with:
          github_token: ${{ secrets.GITHUB_TOKEN }}

In the CI job, I found the job showed false success but actually there were errors.
https://github.com/Bai-Yingjie/Bai-Yingjie.github.io/actions/runs/3270326269/jobs/5378819258

I looked the code entrypoint.sh, can we put set -e earlier than gitbook build to catch errors?

@tuliren
Copy link
Owner

tuliren commented Oct 19, 2022

Thank you for creating this issue. I have added set -e at the beginning of entrypoint.sh. Please give v1.0.1 a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants