Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cata Classic] Enounter Bar saved location not respected #858

Closed
Road-block opened this issue May 24, 2024 · 3 comments
Closed

[Cata Classic] Enounter Bar saved location not respected #858

Road-block opened this issue May 24, 2024 · 3 comments
Assignees
Labels
cata Cataclysm Classic (4.4.x)

Comments

@Road-block
Copy link

When reporting an issue, please try to reproduce the issue with just Dominos and Dominos_Config running. Dominos reuses a good chunk of the stock UI, and other popular addons, like Move Anything, like to take control of those parts, too.

Addon Version
You can get this via running /dominos version in game
10.2.30-cata

World of Warcraft Version
For example, Classic, Retail, PTR, Beta.
Cataclysm Classic

The Encounter Bar (shows Alt PowerBar from what I can tell? for when it shows up)
I have saved to a specific location (center bottom closer to my actionbars)
The move overlay at that location with /dominos config so it doesn't seem to be a persistence issue.

Unexpected behavior.
Regardless where it is saved it pops up at the default location when it shows up during fights.

@Tuller Tuller added the cata Cataclysm Classic (4.4.x) label May 26, 2024
@Road-block
Copy link
Author

Road-block commented Jun 1, 2024

I restored a line that was commented out - in my local copy - and that seems to have fixed the issue (alt power bar showed at the saved location on Chogal with corruption mechanic)

The line in question being Dominos/bars/encounterBar.lua#L78

I have no idea if there needs to be conditional code for other client versions as I don't play mainline.

@Tuller Tuller closed this as completed in d3e85ef Jun 1, 2024
@Tuller
Copy link
Member

Tuller commented Jun 1, 2024

Thanks. I've put the setting behind a client check because it isn't necessary in retail

@kbinz
Copy link

kbinz commented Jun 11, 2024

The fix doesn't work for me after a death. /rl helps
Version 10.2.32

dominos_encounter_bar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cata Cataclysm Classic (4.4.x)
Projects
None yet
Development

No branches or pull requests

3 participants