Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] min-height / min-width not working correctly #53

Closed
eileenoo opened this issue Jun 16, 2020 · 7 comments
Closed

[UI] min-height / min-width not working correctly #53

eileenoo opened this issue Jun 16, 2020 · 7 comments
Assignees
Labels
bug Something isn't working prio:low

Comments

@eileenoo
Copy link
Collaborator

A minimum height and width of the electron window was added with this issue: #48
Due to this, the view is scrollable horizontally when the size expands the min. width.

Somehow the bg is not updated accordingly (see screenshot)
Screenshot 2020-06-16 at 13 27 54

@eileenoo eileenoo added the bug Something isn't working label Jun 16, 2020
@eileenoo
Copy link
Collaborator Author

The min. width / height can either be removed (as the UI was updated to resize, or this needs to be fixed.

@egekorkan
Copy link
Member

Then it can be removed, @Fady222 what do you think and do you see the same behavior?

@FadySalama
Copy link
Member

FadySalama commented Jun 16, 2020

I can confirm bug.
Removing minimum height and width would allow the user to basically minimize the window all the way down to being not visible at all. If that is acceptable then it can be removed. @egekorkan @neniman

A quick fix would be to disable scrolling in CSS

Edit: added quick fix

@egekorkan
Copy link
Member

I would say that there should be a minimum but if this CSS fix does not solve it, then we should remove it.
@Fady222 where is the fix?

@FadySalama
Copy link
Member

@egekorkan Didn't do it yet. Would do it by today or by tomorrow at most

@eileenoo
Copy link
Collaborator Author

I can confirm bug.
Removing minimum height and width would allow the user to basically minimize the window all the way down to being not visible at all. If that is acceptable then it can be removed. @egekorkan @neniman

A quick fix would be to disable scrolling in CSS

Edit: added quick fix

If you disable scrolling, some content would not be visible.. so we have to find another solution / remove it 🌝 @Fady222

This was referenced Jul 1, 2020
@FadySalama
Copy link
Member

This issue is already resolved. Should we close it? @egekorkan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working prio:low
Projects
None yet
Development

No branches or pull requests

3 participants